feat: env var to control libxml2 memory management #2843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
This allows a user to opt into configuring libxml2 to use system
malloc
instead of ruby'sruby_xmalloc
(which is the default on all platforms except windows using system DLLs).This addresses a few problems:
ruby_xfree
won't segfault if called afterruby_vm_destruct
ruby/ruby#7663Parsing benchmarks:
Serialization benchmarks:
I'm not making this the default right now -- though we should consider doing so in the future -- because in production environments, it may change the memory usage behavior.
Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
No functional changes.
cc @byroot and @tenderlove