Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node-sass from 4.14.1 to 5.0.0 #1079

Closed
wants to merge 1 commit into from
Closed

Bump node-sass from 4.14.1 to 5.0.0 #1079

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2021 •
edited
Loading

Bumps node-sass from 4.14.1 to 5.0.0.

Release notes

Sourced from node-sass's releases.

v5.0.0

Breaking changes

  • Only support LTS and current Node versions (@nschonni)
  • Remove deprecated process.sass API (@xzyfer, #2986)

Features

  • Add support for Node 15
  • New node-gyp version that supports building with Python 3

Community

Fixes

Supported Environments

OS Architecture Node
Windows x86 & x64 10, 12, 14, 15
OSX x64 10, 12, 14, 15
Linux* x64 10, 12, 14, 15
Alpine Linux x64 10, 12, 14, 15
FreeBSD i386 amd64 10, 12, 13

*Linux support refers to major distributions like Ubuntu, and Debian

Commits
  • 0648b5a chore: Add Node 15 support (#2983)
  • e2391c2 Add a deprecation message to the readme (#3011)
  • 6a33e53 chore: Don't upload artifacts on PRs
  • d763506 chore: Only run coverage on main repo
  • d4ebe72 build(deps): update actions/setup-node requirement to v2.1.2
  • 2bebe05 build(deps-dev): bump rimraf from 2.7.1 to 3.0.2
  • f877689 chore: Don't double build DependaBot PRs
  • b48fac4 chore: Add weekly DependaBot updates
  • 91c40a0 Remove deprecated process.sass API
  • 1f6df86 Replace lodash/assign in favor of the native Object.assign
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 17, 2021
@0xdevalias 0xdevalias self-requested a review January 17, 2021 21:53
@0xdevalias 0xdevalias self-assigned this Jan 17, 2021
@0xdevalias
Copy link
Contributor

See #850 for more context on this update.. from memory there are a bunch of nuances and such that may cause breaking changes.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/staging/node-sass-5.0.0 branch from 1cb5f3f to b685f8d Compare January 25, 2021 02:41
@dependabot
Bump node-sass from 4.14.1 to 5.0.0
4c77996 
Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](sass/node-sass@v4.14.1...v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/staging/node-sass-5.0.0 branch from b685f8d to 4c77996 Compare January 25, 2021 02:53
@codeclimate
Copy link

codeclimate bot commented Jan 25, 2021

Code Climate has analyzed commit 4c77996 and detected 0 issues on this pull request.

View more on Code Climate.

@0xdevalias 0xdevalias mentioned this pull request Jan 25, 2021
Merged
3 tasks
@0xdevalias
Copy link
Contributor

0xdevalias commented Jan 25, 2021 •
edited
Loading

From #850:

Since we already seem to be using a version of saas-loader that supports the non-deprecated dart-sass, and because create-react-app's react-scripts doesn't seem to support node-sass v5 yet (targeted for 4.0.2 milestone), I think our best way forward here is to switch to using dart-sass instead of this.

See #1103

@0xdevalias 0xdevalias closed this Jan 25, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 25, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@0xdevalias 0xdevalias deleted the dependabot/npm_and_yarn/staging/node-sass-5.0.0 branch January 25, 2021 03:37
This was referenced Jan 25, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdevalias 0xdevalias Awaiting requested review from 0xdevalias

Assignees

@0xdevalias 0xdevalias

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xdevalias