Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: root path spa will get redirect loop #364

Closed
kunyan opened this issue Apr 20, 2020 · 2 comments · Fixed by #369
Closed

[Bug]: root path spa will get redirect loop #364

kunyan opened this issue Apr 20, 2020 · 2 comments · Fixed by #369
Assignees
Labels
bug Something isn't working router SPAship Router

Comments

@kunyan
Copy link
Contributor

kunyan commented Apr 20, 2020

Describe the bug:

When we access the router root path, it should return the root spa
However, it will add // in the end and redirect loop

Steps to reproduce:

Expected behavior:

Root path SPA display

Screenshots:

Screen Shot 2020-04-20 at 7 03 27 PM

Environment;

  • Operating System(s): Linux/macOS/Windows [Variant and Version]
  • Browser: Firefox/Chrome/Safari [Version] / Other (please specify)

Tell us more about your product/project and timeline to help prioritize this issue:

Additional context

@kunyan kunyan added bug Something isn't working router SPAship Router labels Apr 20, 2020
@Jared-Sprague
Copy link
Contributor

This is due to the changes in common flatpath. I implemented the special logic outside of the common package in router, I think we should do the same for API, or re-implement the changes in router to based on the common package changes.

@Jared-Sprague
Copy link
Contributor

Caused by #361

I think a small bit of logic in router should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working router SPAship Router
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants