Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #364 - redirect root at root path spa #369

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fixes #364 - redirect root at root path spa #369

merged 1 commit into from
Apr 21, 2020

Conversation

Jared-Sprague
Copy link
Contributor

Closes / Fixes / Resolves

Fixes #364

Explain the feature/fix

Fixes redirect loop at root path /

Does this PR introduce a breaking change

No

@Jared-Sprague Jared-Sprague added the router SPAship Router label Apr 20, 2020
@Jared-Sprague Jared-Sprague added this to the [MVP] Required features milestone Apr 20, 2020
@github-actions github-actions bot requested a review from mwcz April 20, 2020 18:50
kunyan
kunyan approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@kunyan kunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM and verified on Dev

@kunyan kunyan merged commit af8688c into master Apr 21, 2020
@sayak-sarkar sayak-sarkar deleted the redirectLoopFix branch April 21, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayak-sarkar sayak-sarkar sayak-sarkar approved these changes

@kunyan kunyan kunyan approved these changes

@mwcz mwcz Awaiting requested review from mwcz

Assignees
No one assigned
Labels
router SPAship Router
Projects
None yet
Milestone
[MVP] Required features
Development

Successfully merging this pull request may close these issues.

[Bug]: root path spa will get redirect loop
3 participants
@Jared-Sprague @kunyan @sayak-sarkar