Update template name changed in nbconvert development version #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And as soon as I opened the PR, I realised that was a bad way to do it. I've redone it to get the default template name from nbconvert, which should work with old and new nbconvert. If you're happy with that, feel free to squash the commits together. |
|
Thanks for the nicely backwards-compatible fix! |
|
Thanks - I've made a PR for nbconvert to use the development version of nbsphinx (jupyter/nbconvert#1133). You might want to wait until nbconvert 6 is out, just in case the templates get changed again. |
|
(In principle what I did should work even if the name changes again, but you never know what could happen) |
matthew-brett
added a commit
to matthew-brett/nb2plots
that referenced
this pull request
Jan 2, 2020
Code from spatialaudio/nbsphinx#344 with thanks.
matthew-brett
added a commit
to matthew-brett/nb2plots
that referenced
this pull request
Jan 2, 2020
Code from spatialaudio/nbsphinx#344 with thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template name is changing in nbconvert 6 - see jupyter/nbconvert#1056 .
I don't know if you want to do a hard change like this, or detect the nbconvert version and switch the name as appropriate. But the change breaks nbconvert building its own docs.- EDIT: it now gets the default template name from nbconvert.