Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: adds basic testing framework #58

Closed
wants to merge 1 commit into from

Conversation

stsievert
Copy link

This implements a basic testing framework, as mentioned in #57. Going off the py.test/nose/etc testing framework, I tried to implement some basic tests in tests/.

My one test (below) didn't pass (threw NotJSON error) but at least the test is here now, and I'll let you work out the details.

def test_basic_parse():
    n = NotebookParser()
    n.parse('Basic.ipynb', 'basic.rst')

@mgeier
Copy link
Member

mgeier commented Jul 27, 2016

Thanks for this PR.

The error you are getting is because the NotebookParser doesn't work like that. The input arguments are a string containing the actual contents of a notebook file (not its file name) and an empty docutils "document" object. See the documentation of docutils.parsers.rst.Parser.parse().

BTW, there are no .rst files involved in the API and there shouldn't be in the tests either, because with #36 there won't be intermediate .rst files anymore.

[...] and I'll let you work out the details.

I won't. And it's not for a lack of understanding. As I said in #57 (comment), I don't have the time or energy to implement proper automated tests. But it would be great if you could do it!

@mgeier mgeier mentioned this pull request Oct 20, 2016
@mgeier
Copy link
Member

mgeier commented Nov 23, 2016

I'm closing this for lack of activity.

If somebody wants to add automated testing, feel free to create another PR!

@mgeier mgeier closed this Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants