This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Queue RPCs by Worker_EntityId #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-valy
approved these changes
Jul 9, 2019
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
m-samiec
reviewed
Jul 9, 2019
m-samiec
reviewed
Jul 9, 2019
improbable-valy
pushed a commit
that referenced
this pull request
Jul 10, 2019
* Queue RPCs by Worker_EntityId * Apply suggestions from code review Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Changed Worker_EntityId to Worker_EntityId_Key for Linux compilation. Fixed function signature * Moved initialisation inside if statements
improbable-valy
added a commit
that referenced
this pull request
Jul 10, 2019
* Queue RPCs by Worker_EntityId * Apply suggestions from code review Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Changed Worker_EntityId to Worker_EntityId_Key for Linux compilation. Fixed function signature * Moved initialisation inside if statements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
RPCs are now guaranteed to arrive in the same order per target actor, i.e. for the actor and all of its subobjects.
Release note
RPCs are now guaranteed to arrive in the same order per target actor, i.e. for the actor and all of its subobjects.
Tests
RPC ordering should be the same as in original UE4 implementation.
Documentation
RPCs are now guaranteed to arrive in the same order per target actor, i.e. for the actor and all of its subobjects.
Primary reviewers
@improbable-valentyn @m-samiec