This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Bugfix - Fix up Fast Local Restart issues #1139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahuburn
requested review from
aleximprobable,
m-samiec and
mattyoung-improbable
July 10, 2019 10:16
joshuahuburn
force-pushed
the
bugfix/FLR-fixes
branch
from
July 10, 2019 10:37
f72b297
to
38d5a6d
Compare
aleximprobable
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks safer now! :)
…al service is in the wrong project
improbable-prow-robot
added
the
size/L
Denotes a PR that changes 150-299 lines, ignoring generated files.
label
Jul 10, 2019
m-samiec
changed the title
Bugfix - Fiix up Fast Local Restart issues
Bugfix - Fix up Fast Local Restart issues
Jul 10, 2019
improbable-prow-robot
added
the
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
label
Jul 10, 2019
m-samiec
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/L
Denotes a PR that changes 150-299 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Various bug fixes for issues found with Fast Local Restart.