This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1710 Fixed a crash that may happen if rpcs are sent to tornoff actor #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1710 |
improbable-prow-robot
added
jira/UNR
size/XS
peterimprobable
approved these changes
Jul 11, 2019
improbable-valy
approved these changes
Jul 11, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
mattyoung-improbable
approved these changes
Jul 11, 2019
…river.cpp Co-Authored-By: Matt Young <matthewyoung@improbable.io>
|
Use of bTearOff gives compilation warning |
|
warning C4996: 'AActor::bTearOff': Use GetTearOff() or TearOff() functions. This property will become private. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
In some cases RPCs might be sent to AActor that's been tornoff. This PR eliminates such cases.
Release note
Fix for an issue that didn't get to known issues yet.
Tests
This was experienced when a ragdoll was caught in an explosion.
Documentation
No doc update.
Primary reviewers
@mattyoung-improbable @improbable-valentyn