This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1735 #1177
Merged
UNR-1735 #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ands on external schema generated code.
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1735 |
improbable-prow-robot
added
the
size/XS
al1y
reviewed
Jul 18, 2019
| {Text.Indent(1, $@"auto Response = {Types.GetTypeDisplayName(component.QualifiedName)}::Commands::{Text.SnakeCaseToPascalCase(command.Name)}::Response({Types.GetTypeDisplayName(component.QualifiedName)}::Commands::{ Text.SnakeCaseToPascalCase(command.Name)}::Response::Type::Deserialize(Schema_GetCommandResponseObject(Op.response.schema_type))); | ||
| {Text.Indent(1, $@"if (Op.command_id == {command.CommandIndex}) | ||
| {{ | ||
| {Text.Indent(1, $@"auto Response = Op.status_code == Worker_StatusCode::WORKER_STATUS_CODE_SUCCESS ? {Types.GetTypeDisplayName(component.QualifiedName)}::Commands::{Text.SnakeCaseToPascalCase(command.Name)}::Response({Types.GetTypeDisplayName(component.QualifiedName)}::Commands::{ Text.SnakeCaseToPascalCase(command.Name)}::Response::Type::Deserialize(Schema_GetCommandResponseObject(Op.response.schema_type))) : {Types.GetTypeDisplayName(component.QualifiedName)}::Commands::{Text.SnakeCaseToPascalCase(command.Name)}::Response(); |
There was a problem hiding this comment.
this line is a monster, maybe split onto 3 lines? other than that lgtm
There was a problem hiding this comment.
Fixed.
al1y
approved these changes
Jul 18, 2019
m-samiec
approved these changes
Jul 21, 2019
improbable-davidrodriguez
deleted the
bugfix/UNR-1735-external-schema-codegen-fix
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for generated code from external schema to call the right callbacks.
Description
Added control flow to prevent callbacks for all commands in a component to be called when a single one should.
Release note
External schema codegen tool is a new feature and this is a fix to that feature so there is no need for release note changes.
Tests
How did you test these changes prior to submitting this pull request?
Before the fix, getting a response to one command of a component would trigger the callback for all commands in that component. With the fix, this no longer happens and only the right callback is being called.
What automated tests are included in this PR?
None.
STRONGLY SUGGESTED: How can this be verified by QA?
Using a project that includes external schema with one component that has several commands and registering to several callbacks and seeing that only the right one is being called (This bug was discovered and tested in the upcoming DBSync Worker UnrealGDK tutorial).
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Bugfix, no documentation needed.
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.