This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1757 Skip actor itself when iterating ReplicationMap when creating entity #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1757 |
improbable-prow-robot
added
jira/UNR
size/XS
Vatyx
approved these changes
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Actor's replicator is also contained in
ReplicationMap. We weren't explicitly checking for it, and that caused the unresolved objects to be added twice, which shouldn't happen.On a side note, the only reason we had an unresolved object was because of a torn off actor which was referenced by the actor whose entity was being created.
Primary reviewers
@m-samiec