This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Updated ExternalSchemaCodegen.bat to take a project path argument #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XS
Denotes a PR that changes 0-14 lines, ignoring generated files.
labels
Jul 30, 2019
m-samiec
reviewed
Jul 30, 2019
m-samiec
reviewed
Jul 30, 2019
m-samiec
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - @ernopp can we be sure we've caught all doc usecases of this batch script?
improbable-prow-robot
added
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-14 lines, ignoring generated files.
labels
Jul 30, 2019
improbable-prow-robot
added
size/S
Denotes a PR that changes 15-39 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
labels
Jul 30, 2019
improbable-valy
approved these changes
Jul 30, 2019
al1y
reviewed
Jul 30, 2019
al1y
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment, otherwise lgtm
improbable-prow-robot
added
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 15-39 lines, ignoring generated files.
labels
Jul 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Describe your changes here.
Release note
REQUIRED: Add a release note to the
##Unreleased
section of CHANGELOG.md. You can find guidance for writing useful release notes here. Documentation changes are exempt from this requirement.Tests
How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?
STRONGLY SUGGESTED: How can this be verified by QA?
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.