Skip to content
This repository has been archived by the owner on Aug 29, 2024. It is now read-only.

Updated ExternalSchemaCodegen.bat to take a project path argument #1244

Merged
merged 4 commits into from
Jul 31, 2019

Conversation

joshuahuburn
Copy link
Contributor

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.


Description

Describe your changes here.

Release note

REQUIRED: Add a release note to the ##Unreleased section of CHANGELOG.md. You can find guidance for writing useful release notes here. Documentation changes are exempt from this requirement.

Tests

How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?

STRONGLY SUGGESTED: How can this be verified by QA?

Documentation

How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@joshuahuburn joshuahuburn self-assigned this Jul 30, 2019
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jul 30, 2019
Copy link
Collaborator

@m-samiec m-samiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - @ernopp can we be sure we've caught all doc usecases of this batch script?

@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jul 30, 2019
@improbable-prow-robot improbable-prow-robot added size/S Denotes a PR that changes 15-39 lines, ignoring generated files. and removed size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Jul 30, 2019
Copy link
Contributor

@al1y al1y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, otherwise lgtm

@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. and removed size/S Denotes a PR that changes 15-39 lines, ignoring generated files. labels Jul 31, 2019
@joshuahuburn joshuahuburn merged commit 19715a1 into 0.6.0-rc Jul 31, 2019
@jared-improbable jared-improbable deleted the bugfix/external-codegen-engine-plugin branch August 1, 2019 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants