This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Feature/refactor spatialos project settings merge #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahuburn
requested review from
b3nav,
improbable-valy and
mattyoung-improbable
improbable-prow-robot
added
jira/no-ticket
b3nav
reviewed
Aug 6, 2019
|
Beautiful |
joshuahuburn
deleted the
feature/refactor-spatialos-project-settings-merge
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
This PR refactors some existing logic that retrieves the SpatialOS project from the spatial.json file and other utility functions from the FLocalDeploymentManager to the FSpatialGDKServicesModule and making them static. It also removes duplicated code from the Cloud settings that retrieves the SpatialOS project name.
Primary reviewers
@mattyoung-improbable @improbable-valentyn