This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1644: Schema compiler failure should fail schema generation #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1644 |
improbable-prow-robot
added
jira/UNR
size/XS
sjtsilvester
force-pushed
the
bugfix/UNR-1644-schema-compiler-wrong-output
branch
from
0d9f428
to
92b307c
Compare
|
|
||
| return true; | ||
| bool SchemaCompileSuccess = RunSchemaCompiler(); |
There was a problem hiding this comment.
SchemaCompileSuccess -> SchemaCompilerSuccess?
Also what about just return RunSchemaCompiler();
SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SpatialGDKEditorSchemaGenerator.cpp
Show resolved
Hide resolved
m-samiec
approved these changes
Aug 13, 2019
joshuahuburn
approved these changes
Aug 14, 2019
improbable-valy
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
UNR-1644: Change SpatialGDKGenerateSchema to cause the window to display "schema generation failed" if schema compilation failed.
Release note
Bugfix: When schema compiler fails, schema generation correctly shows an error.
Tests
Running schema generation normally succeeds as normal. Deleting GDK schema files and running an iterative schema gen correctly produces an output.
How can this be verified by QA?
Run an iterative schema gen that should succeed and confirm the window displays the succeed message, then force the iterative schema gen to fail (e.g. by deleting GDK schema files) and confirming the window displays an error message.
Also, delete the schema descriptor directory in a test project (spatial/build/assembly/schema) and set its parent directory to read-only (right click on directory -> properties -> select security and deny write). Running the full schema gen should fail. Deleting schema descriptor directory without changing access permissions should still result in schema gen success.
Primary reviewers
@joshuahuburn @improbable-valentyn