This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1402: Crash when attempting to replicate a non supported type #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1402 |
improbable-prow-robot
added
jira/UNR
size/XS
m-samiec
reviewed
Aug 13, 2019
| @@ -314,9 +316,13 @@ void ComponentFactory::AddProperty(Schema_Object* Object, Schema_FieldId FieldId | |||
| { | |||
| // These properties can be set to replicate, but won't serialize across the network. | |||
| } | |||
| else if (Property->IsA<UMapProperty>()) | |||
| { | |||
| UE_LOG(LogComponentFactory, Error, TEXT("Replicated TMaps are not supported.")); | |||
There was a problem hiding this comment.
Would be good to indicate to the user which property this is (variable name, class etc.)
m-samiec
reviewed
Aug 13, 2019
| else | ||
| { | ||
| checkf(false, TEXT("Tried to add unknown property in field %d"), FieldId); | ||
| UE_LOG(LogComponentFactory, Error, TEXT("Tried to add unknown property in field %d"), FieldId); |
There was a problem hiding this comment.
What does native unreal do here? I'm more in favour of explicit check rather than potentially missing a replicated prop.
There was a problem hiding this comment.
Each property would have its own NetSerializeItem which prints an error or does nothing if the property can't be replicated.
improbable-prow-robot
added
size/S
improbable-valy
approved these changes
Aug 19, 2019
joshuahuburn
approved these changes
Aug 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Unreal produces a warning (rather than crashing the game) if the game attempts to replicate an unsupported type (such as TMap). This PR changes the GDK to match this behaviour.
Release note
Attempting to replicate unsupported types (such as TMap) produce a log error rather than crashing the game.
Tests
Tested by replicating a TMap in GDKCharacter in the example project and verifying that the game no longer crashed but produced an error.
How can this be verified by QA?
Create an actor that contains a replicated TMap property and play with spatial. The game should run normally with an error message in the output.
Primary reviewers
@joshuahuburn @improbable-valentyn