This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1870 Local Deployment Test #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1870 |
1 similar comment
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1870 |
improbable-prow-robot
added
the
size/L
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 16, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Show resolved
Hide resolved
m-samiec
reviewed
Aug 16, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
…ow worker json name can be specified. Passing LaunchConfigDescription to GenerateDefaultLaunchConfig
improbable-prow-robot
added
size/XL
aleximprobable
commented
Aug 20, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp
Outdated
Show resolved
Hide resolved
…unchConfigGenerator.cpp
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultWorkerJsonGenerator.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultWorkerJsonGenerator.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultWorkerJsonGenerator.cpp
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
| FString BuildConfigArgs = TEXT("worker build build-config"); | ||
| FString WorkerBuildConfigResult; | ||
| int32 ExitCode; | ||
| const FString SpatialExe(TEXT("spatial.exe")); |
There was a problem hiding this comment.
nit: This variable is used in a few places now, would be good to centralise.
There was a problem hiding this comment.
This is something that this PR #1303 will do.
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 20, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
…unchConfigGenerator.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
…rkerJsonGenerator.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
…aunchConfigDescription constructor with worker name. Removed unused code.
improbable-prow-robot
added
size/L
improbable-prow-robot
added
size/XL
m-samiec
reviewed
Aug 21, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Show resolved
Hide resolved
m-samiec
reviewed
Aug 21, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Aug 21, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
m-samiec
reviewed
Aug 21, 2019
SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp
Outdated
Show resolved
Hide resolved
…er/LocalDeploymentManagerTest.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Created Local Deployment tests.
Release note
No CHANGELOG.md update.
Tests
Run SpatialGDK tests - they should be successful.
Documentation
No documentation update.
Primary reviewers
@m-samiec @joshuahuburn