This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Actor Replication Net Relevancy #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
m-samiec
reviewed
Sep 13, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Sep 13, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Sep 13, 2019
m-samiec
reviewed
Sep 13, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
|
Can we test this in an offloading project also? |
improbable-prow-robot
added
size/M
Tested in Example Shooter project with offloading enabled, behaved as expected |
m-samiec
reviewed
Sep 17, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Sep 17, 2019
m-samiec
reviewed
Sep 17, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Sep 17, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Sep 17, 2019
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
improbable-prow-robot
added
size/S
SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp
Outdated
Show resolved
Hide resolved
improbable-valy
approved these changes
Sep 17, 2019
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
improbable-prow-robot
added
size/M
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Add net relevancy check to replicating actors. When prioritizing actors for replication, the position of each actor is checked against the NetViewCullDistance of each player controller present in the game. If the actor is not withing these ranges or is not bAlwaysRelevant, it will no longer be replicated.
Tests
Tested this branch and master branch in a large scale game with Unreal performance stat capturing enabled to diff and performance gain.
Primary reviewers
@m-samiec @improbable-valentyn