This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
[UNR-2735] Correctly report errors when cloud deployment fails to launch #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-valy
requested review from
mironec,
oblm and
MatthewSandfordImprobable
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-2735 |
improbable-prow-robot
added
jira/UNR
size/XS
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ Features listed in the internal section are not ready to use but, in the spirit | |||
|
|
|||
| ### Bug fixes: | |||
| - Replicated references to newly created dynamic subobjects will now be resolved correctly. | |||
| - Cloud deployment flow will now correctly report errors when a deployment fails to launch. | |||
There was a problem hiding this comment.
Perhaps could be more specific here? This does usually happen but now does for an additional failure case.
MatthewSandfordImprobable
approved these changes
Feb 5, 2020
improbable-valy
commented
Feb 5, 2020
mironec
approved these changes
Feb 5, 2020
|
I was thinking if a toast is better than a log, but this will show a failed to start toast, right? Then I guess it's natural to check the log afterwards. |
improbable-valy
deleted the
bugfix/UNR-2735-false-success-on-missing-assembly-0.8.1
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
DeploymentLauncher returned 0 if it failed to launch a deployment. We also weren't printing out the error output from DeploymentLauncher if there was stuff there (e.g. if the project name is wrong which causes the deployment list command to fail).
Primary reviewers
@MatthewSandfordImprobable @mironec