This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
[UNR-2887] Fix: Dynamic subobjects attached near actor creation would not be able to replicate their properties #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-2887 |
improbable-prow-robot
added
jira/UNR
size/S
mironec
commented
Feb 14, 2020
| @@ -538,7 +538,7 @@ void USpatialReceiver::ReceiveActor(Worker_EntityId EntityId) | |||
| if (AActor* EntityActor = Cast<AActor>(PackageMap->GetObjectFromEntityId(EntityId))) | |||
| { | |||
| UE_LOG(LogSpatialReceiver, Log, TEXT("Entity for actor %s has been checked out on the worker which spawned it or is a singleton linked on this worker. " | |||
| "Entity id: $lld"), *EntityActor->GetName(), EntityId); | |||
| "Entity id: %lld"), *EntityActor->GetName(), EntityId); | |||
mironec
commented
Feb 14, 2020
| if (ComponentId == It->component_id) | ||
| { | ||
| Connection->SendComponentUpdate(EntityId, &(*It)); | ||
| It.RemoveCurrent(); |
There was a problem hiding this comment.
No memory corruption?
There was a problem hiding this comment.
Have had to replace the entire code section, now it's kind of less readable. Suggestions welcome
There was a problem hiding this comment.
Replaced back to using an iterator, because we want to preserve order.
|
By the way, I am pretty sure my previous early-resolving of dynamic subobjects breaks dynamic subobjects for which you turn replication on and off :( |
improbable-valy
approved these changes
Feb 18, 2020
m-samiec
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if trying to create and attach a dynamic subobject to an actor near its creation point, the fields of the dynamic component would not replicate properly after initial creation.
The reason for this was that we were not setting component write ACLs properly for these subobjects. This was due to the change made earlier, to resolve dynamic components earlier, which caused the code trying to check if the subobject is dynamically attached to think it was not dynamically attached, since it has already been resolved. This is fixed by decoupling the writing of ACLs from the resolution of the dynamic object in
SpatialSender::CreateEntity.Also a drive-by fix for $lld spam in logs.
Also a drive-by fix for authority queuing not checking which component we got authority over and potentially firing component updates for objects we did not have authority over.
Release note
This actually worked prior to the previous fix to dynamic subobjects (also in this RC), so I think no release note is necessary.
Tests
Augmented dynamic component tests: https://github.com/improbable/UnrealGDKEngineNetTest/pull/8.
Documentation
N/A
Primary reviewers
@improbable-valentyn @Vatyx