This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Removing the netdriver from the spatial worker connection. #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/CHINF-886 |
improbable-prow-robot
added
jira/CHINF
size/M
jessicafalk
reviewed
Mar 5, 2020
| @@ -71,6 +71,12 @@ class SPATIALGDK_API USpatialWorkerConnection : public UObject, public FRunnable | |||
| FReceptionistConfig ReceptionistConfig; | |||
| FLocatorConfig LocatorConfig; | |||
|
|
|||
| DECLARE_DELEGATE(OnConnectionToSpatialOSSucceededDelegate) | |||
| OnConnectionToSpatialOSSucceededDelegate OnConnectedCallback; | |||
There was a problem hiding this comment.
comparing with master and don't see this line there. is this part needed?
oh or is this from the ConnectionManager and we don't have that one in this rc?
There was a problem hiding this comment.
Yes I this was moved to the spatial connection manager. Fun fun fun.
There was a problem hiding this comment.
It exists in the USpatialConnectionManager :D
joshuahuburn
approved these changes
Mar 5, 2020
jessicafalk
approved these changes
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Need to remove all reference to the net driver from the connection. These are changes from master. Simply use a delegate on spatial worker connection that people can bind to if they want to know about successful or failing spatial connection attempts.