Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Change screenshotQuality property type to integer #810

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[Fix] Change screenshotQuality property type to integer #810

merged 1 commit into from
Jan 2, 2024

Conversation

orkhanahmadov
Copy link
Contributor

Currently, this property is defined as a nullable string. Puppeteer throws an exception when setting screenshot quality.

Error: Expected options.quality to be a number but found string at assert (/opt/nodejs/node_modules/puppeteer-core/lib/cjs/puppeteer/util/assert.js:28:15) at CDPPage.screenshot (/opt/nodejs/node_modules/puppeteer-core/lib/cjs/puppeteer/common/Page.js:777:36)

@orkhanahmadov orkhanahmadov marked this pull request as ready for review January 2, 2024 10:42
@freekmurze freekmurze merged commit 04b3527 into spatie:main Jan 2, 2024
5 checks passed
@freekmurze
Copy link
Member

Thanks!

@orkhanahmadov orkhanahmadov deleted the patch-1 branch January 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants