New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect history test #836

Merged

freekmurze merged 1 commit into spatie:main from niclas-timm:fix-redirects

Apr 2, 2024

Contributor

niclas-timm commented Apr 1, 2024

When testing the redirect history on http://www.spatie.be, the test expected 3 redirects:

http://www.spatie.be -> http://www.spatie.be/ (trailing "/")
http://www.spatie.be/ -> https://www.spatie.be/ (https)
https://www.spatie.be/ -> https://spatie.be/ (remove "www")

However, the first two now happen in one redirect, i.e.:

http://www.spatie.be -> https://www.spatie.be/ (https + trailing "/")
https://www.spatie.be/ -> https://spatie.be/ (remove "www")

Therefore, I altered the test to expect only two redirects instead of three.

I assume that the test failed due to a change on the spatie.be domain.


          Fix redirect history test

7f999fa

freekmurze merged commit fc3e9d0 into spatie:main

1 of 5 checks passed

Member

freekmurze commented Apr 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet