Add National and Revolutionary Iran Holidays #146
Conversation
src/Countries/Iran.php
Outdated
| ->setTimezone('Asia/Tehran'); | ||
|
|
||
| return [ | ||
| //add more holidays |
There was a problem hiding this comment.
Some countries already solved the Islamic holidays part.
https://github.com/spatie/holidays/blob/main/src/Countries/Turkey.php#L11
There was a problem hiding this comment.
We have 2 types of holidays in Iran.
In the first step (this PR) I added national and revolutionary holidays because these types of holidays are always fixed and do not change every year.
We(Iran) only share the Ramadan and Eid al-Ghadir holidays with Turkey. So, I'm adding "Religious (Islamic) holidays" to another PR because I need to double-check with the solar calendar.
There was a problem hiding this comment.
Sounds good. Would it make sense to return Farsi(?) by default instead of English?
You can add translations here: https://github.com/spatie/holidays/tree/main/lang
There was a problem hiding this comment.
Yes, Thank you for this. Return to Farsi language is much more useful for Farsi language users. ❤️
I applied this change.
alisalehi1380
changed the title
| $result = Holidays::for(country: 'ir', year: null, locale: $locale)->get(); | ||
|
|
||
| expect($result)->toBeArray(); | ||
| expect($result[7]['name'])->toBe($newYearsDayName); |
There was a problem hiding this comment.
I chose the 7th date of the holidays array because it is far from any political and ethnic front. 🤝
|
|
test pass ✅
holiday names according to Wikipedia ✅
Dates that are converted to solar are completely correct and usable. ✅
