-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon is not mandatory, we can use php DateTime objects #115
Conversation
Take a look at |
62efc2b
to
07586cb
Compare
I'm sorry... It was a big mistake ... I replaced it with Backward Compatibility. Not sure it's a good idea to let the test with Carbon implementation because here we don't use any specific carbon feature since i replaced Carbon::minValue Carbon::maxValue by private methods which reproduce Carbon implementation. Just say me if you want me to delete the test with Carbon implementation. |
07586cb
to
04445a9
Compare
@freekmurze, I hope you had a great holiday! |
Sorry, but anyone is here? 🆘 |
Any news here? @stephpy - seems like you resolved the two raised issues from @freekmurze but not import the namespace / switch from private to protected? |
@Isengo1989 I did both :) |
Thanks! |
Hello,
Carbon should not be a mandatory requirements since PHP provides DateTimeInterface since php >5.5
I let a test with your carbon implementation to prove it.
This version of carbon has itself some requirements (Symfony <7.0) which makes me unconfortable that's why I checked if it's really needed here. It's not the case.
Regards