Update Image.php #211
Merged
Update Image.php #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bug related to Deserialization of Untrusted Data
Fix bugs related to Deserialization of Untrusted Data
|
It seems the tests are failing, could you have a look? |
|
It seems that your test case includes some exceptional scenarios that cause the creation of the Image object to throw an error, preventing it from entering the copy function. I am a security researcher, not a developer, so I can only offer ideas for fixes. You can rely on the code snippet I've written to modify it to fit the test cases. |
Sonicrrrr
commented
Mar 6, 2024
Fix phar deserialization vulnerability
Update code to fix vulnerability
|
I have made a pull request to fix the above vulnerability, can you merge it into your code? |
|
@Sonicrrrr looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug related to Deserialization of Untrusted Data