"Fit::Crop" malfunction

[wemadefoxnever]

Hi, everybody! I have a problem with Fit:crop function. Advice or help, please.

https://spatie.be/docs/image/v3/image-manipulations/resizing-images#content-fitcrop
About Fit:Crop

Resizes the image to fill the width and height boundaries and crops any excess image data. The resulting image will match the width and height constraints without distorting the image.

My model config:

class Course extends Model implements HasMedia
{
    use InteractsWithMedia;
    public function registerMediaConversions(Media $media = null): void
    {
        $this
            ->addMediaConversion('cover')
            ->format('webp')
            ->fit(Fit::Crop, 600, 450)
            ->withResponsiveImages()
            ->optimize();
    }
}

As it appears, the script didn't crop the excess but merely compressed the image to the required dimensions. This strongly resembles a bug.
Original image:

Convertion image (Sorry for the JPG. GitHub doesn't support the WebP format, so I had to replace it with JPG.")

[whousehomestay]

Yeah, i got this too...

[lukasleitsch]

Having the same issue. I can reproduce the bug with this snippet.

\Spatie\Image\Image::useImageDriver(ImageDriver::Gd)
    ->loadFile('example.jpg')
    ->fit(\Spatie\Image\Enums\Fit::Crop, 300, 300)
    ->save('example-cropped.jpg');

[dev]

Same issue here! v3.3.2

[timvandijck]

I just tagged a new version (3.3.3) that should resolve this issue.

[timvandijck]

Seems like there's still a small issue when upscaling, looking into it.

[ghost]

Hi. How do I upgrade this from Media Library Package? The media-library package still uses 3.3.2 and the issue still persist. Do I install this package to make it work?

[timvandijck]

@anuzpandey5 I believe you could just require 3.3.3 in your project composer file and media library should also use that one. I'll update the dependency in medialibrary when this feature is more stable.

[ghost]

@timvandijck Yes I did upgrade it and the problem is solved. Now the major issue is Fit::Crop has the behavior of Fit::Fill

[goyne]

I was facing the same issue using 3.3.2. After upgrading to 3.3.3 the distortion is gone, but white space is added to meet the given width and height boundaries (instead of cropping). Looks like Fit::Crop now has the behaviour of Fit::Fill.

Edited: not clearly visible due to white on white, but the photo has a white bar at the top and bottom. The original does not have that.

[whousehomestay]

Maybe because of this?

#223 (reply in thread)

[goyne]

Not sure if this is caused by upscaling. Original image is much larger.

[timvandijck]

Yeah, there are still some kinks to work out. I'm going to do some more work on it this week to improve things.

[timvandijck]

I just published versions 3.3.4 with some additional fixes to fit cropping. These should resolve the white borders you might get on certain images.