Add DatabaseSizeCheck #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 10.x Compatibility
Fix empty output when running `artisan health:list --fresh`
|
Very nice work, thank you! However the tests are failing? Could you take a look at that? |
|
Thanks! Updated to use |
|
Rebased on main, could you approve the tests run? |
|
OK, could you give it another try? 🙂 |
|
We're all good, thanks again for this excellent PR! |
|
Thanks ❤️ You and the Spatie team thank you for the great package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new check called
DatabaseSizeCheck. This check does what the name says – it fails when the size of the database reaches a certain threshold.I decided to use GB as the order of magnitude instead of MB, since databases that are <1 GB usually aren't causing that much problems.
Thanks!