Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional rector #331

Closed
wants to merge 2 commits into from
Closed

Optional rector #331

wants to merge 2 commits into from

Conversation

lloricode
Copy link

No description provided.

@IonBazan
Copy link

IonBazan commented Feb 8, 2024

I think this requirement should not belong here and instead, should be added into suggests section. We could check if the Rector is installed in the CleanRayCommand itself and throw an error if it's not instead of adding a dependency, especially that some people might install spatie/laravel-ray as non-dev dependency, causing Rector to be loaded into their production app.

@lloricode
Copy link
Author

I think this requirement should not belong here and instead, should be added into suggests section. We could check if the Rector is installed in the CleanRayCommand itself and throw an error if it's not instead of adding a dependency, especially that some people might install spatie/laravel-ray as non-dev dependency, causing Rector to be loaded into their production app.

I totally aggree regarding usage of production

@lloricode lloricode changed the title Support stable rector v1 Optional rector Feb 9, 2024
@lloricode lloricode closed this Feb 13, 2024
@lloricode lloricode deleted the patch-1 branch February 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants