Send attachment data to Ray #357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! @sebastienhenau Could you add support for this in the Ray app? |
patinthehat
reviewed
Jul 19, 2024
| 'filename' => $attachmentPart->getFilename(), | ||
| 'content_id' => $attachmentPart->getContentId(), | ||
| 'content_type' => $attachmentPart->getContentType(), | ||
| 'content' => base64_encode($attachmentPart->getContent()), |
There was a problem hiding this comment.
Is it worth checking the size of the content before doing this? Ray can sometimes struggle a bit with large payloads in my experience.
patinthehat
reviewed
Jul 19, 2024
| return $this->markdown('mails.test'); | ||
| return $this->markdown('mails.test') | ||
| ->attachData('file1', 'file_1.txt') | ||
| ->attachData('file2', 'file_2.txt'); |
There was a problem hiding this comment.
Do we want to test attaching binary files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs an update to Ray to display the attachments (and download them).