Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use composer/pcre for all things regexp #401

Closed
spaze opened this issue Oct 6, 2024 · 0 comments · Fixed by #416
Closed

Use composer/pcre for all things regexp #401

spaze opened this issue Oct 6, 2024 · 0 comments · Fixed by #416
Assignees
@spaze
Labels
enhancement New feature or request

Comments

@spaze
Copy link
Owner

spaze commented Oct 6, 2024

Use https://github.com/composer/pcre instead of pcre_* functions and also instead of Nette\Utils\Strings::match*(). Currently I seem to be using both. Add them to disallowed-calls.neon once the migration is over.

composer/pcre also comes with a PHPStan extension, so use that as well.
@spaze spaze added the enhancement New feature or request label Oct 6, 2024
@spaze spaze self-assigned this Oct 6, 2024
spaze added a commit that referenced this issue Oct 20, 2024
@spaze
Use composer/preg's Regex class instead of preg_*() and Strings::*()
e07b5a5 
Also use the provided PHPStan extension to check regular expressions.

Close #401
@spaze spaze mentioned this issue Oct 20, 2024
Merged
spaze added a commit that referenced this issue Oct 20, 2024
@spaze
Use composer/preg's Regex class instead of preg_*() and Strings::*()
a9a92be 
Also use the provided PHPStan extension to check regular expressions.

Close #401
spaze added a commit that referenced this issue Oct 20, 2024
@spaze
Use composer/pcre for better regexp static analysis (#416)
00f510c 
Use composer/preg's Regex class instead of `preg_*()` and `Strings::*()`.
Also use the provided PHPStan extension to check regular expressions.

Close #401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spaze spaze

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use composer/pcre for better regexp static analysis spaze/michalspacek.cz
1 participant
@spaze