PHPStan level 9 progress #155

spaze · 2023-06-27T18:23:06Z

From 84 errors down to 25.

Resolves these errors: ``` ------ ------------------------------------------------- Line app/Www/Presenters/ErrorPresenter.php ------ ------------------------------------------------- 76 Cannot call method getParameter() on mixed. 76 Cannot call method getPresenterName() on mixed. 91 Cannot call method getParameters() on mixed. ------ ------------------------------------------------- ```

Resolves these errors: ``` ------ ------------------------------------------- Line app/Www/Presenters/BaseErrorPresenter.php ------ ------------------------------------------- 58 Cannot call method getCode() on mixed. 58 Cannot call method getFile() on mixed. 58 Cannot call method getLine() on mixed. 58 Cannot call method getMessage() on mixed. ------ ------------------------------------------- ```

…st what's needed at the moment Resolves these errors: ``` ------ ------------------------------------------------------------------------------------------------------------------ Line app/Tls/CertificateFactory.php ------ ------------------------------------------------------------------------------------------------------------------ 50 Cannot access offset 'commonName' on mixed. 50 Parameter #1 $commonName of class MichalSpacekCz\Tls\Certificate constructor expects string, mixed given. 52 Cannot cast mixed to string. 53 Cannot cast mixed to string. 55 Parameter #6 $serialNumber of class MichalSpacekCz\Tls\Certificate constructor expects string|null, mixed given. ------ ------------------------------------------------------------------------------------------------------------------ ```

…ette\Schema Resolves ``` ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line app/Tls/CertificatesApiClient.php ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 69 Parameter #1 $details of method MichalSpacekCz\Tls\CertificateFactory::fromArray() expects array{commonName: string, commonNameExt: string|null, notBefore: string, notBeforeTz: string, notAfter: string, notAfterTz: string, expiringThreshold: int, serialNumber: string|null, ...}, mixed given. ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ```

This was easy, removes this: ``` ------ ------------------------------------------------------------------------------------------------ Line app/Test/NoOpTranslator.php ------ ------------------------------------------------------------------------------------------------ 36 Method MichalSpacekCz\Test\NoOpTranslator::translate() should return string but returns mixed. ------ ------------------------------------------------------------------------------------------------ ```

This is sort of a duplication of what's already defined in the schema but here we are. Solves these: ``` ------ ---------------------------------------------------- Line app/Pulse/Passwords/AlgorithmAttributesFactory.php ------ ---------------------------------------------------- 37 Cannot access property $inner on mixed. 37 Cannot access property $outer on mixed. 37 Cannot access property $params on mixed. ------ ---------------------------------------------------- ```

…the future Right now, `Nette\Http\Request::getCookie()` returns mixed and would require we check for strings all the time

Currently, `$form->onValidate` and `$form->onSuccess` types for `$values` are specified as `mixed` and the type in the callbacks cannot be narrower as seen in errors like: ``` ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line app/Form/TrainingApplicationAdminFormFactory.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 96 Property Nette\Forms\Form::$onSuccess (array<callable(Nette\Application\UI\Form, mixed): void>) does not accept non-empty-array<(callable(Nette\Application\UI\Form, mixed): void)|(Closure(Nette\Application\UI\Form, stdClass): void)>. 💡 Type stdClass of parameter #2 $values of passed callable needs to be same or wider than parameter type mixed of accepting callable. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ```

Resolves: ``` ------ ----------------------------------------------------------------------- Line app/UpcKeys/Technicolor.php ------ ----------------------------------------------------------------------- 88 Parameter #2 $string of function explode expects string, mixed given. ------ ----------------------------------------------------------------------- ```

… is an int

This is kinda unrelated but I still like it.

Fix ``` ------ --------------------------------------------------------------- Line app/Test/Application/ApplicationPresenter.php ------ --------------------------------------------------------------- 38 Parameter #2 $ of closure expects array<string>, array given. ------ --------------------------------------------------------------- ```

Fixes these errors: ``` ------ -------------------------------------------------------------------------------------------- Line app/Training/Dates/TrainingDatesFormValidator.php ------ -------------------------------------------------------------------------------------------- 18 Parameter #1 $datetime of class DateTimeImmutable constructor expects string, mixed given. 19 Parameter #1 $datetime of class DateTimeImmutable constructor expects string, mixed given. ------ -------------------------------------------------------------------------------------------- ```

It was either PhpStorm complaining that the right part of `$slideNumber ?? ...` is useless, or PHPStan complaining that "Cannot access property $number on mixed." Or both.

Don't care if not because it's gonna be a string, trust me.

…ust Exception Introduced somewhere in #155

… just `Exception` (#165) Introduced somewhere in #155

spaze added 21 commits June 24, 2023 14:23

Add HttpInput service to get cookies as strings and possibly more in …

6e9af53

…the future Right now, `Nette\Http\Request::getCookie()` returns mixed and would require we check for strings all the time

Can remove the test type

ca4edc6

Recommended links now as specific objects

79c2cc1

Add methods to get post data as a string or as an array, and use them

f4a796e

Make sure that logged-in user's identity username is a string, and id…

a3dfcc1

… is an int

Make sure training status id is always an integer

f1a8b3b

Throw specific exception instead of RuntimeException

4ce4239

This is kinda unrelated but I still like it.

Pass an array of certificates to log, not just an array of some data

da519cb

Make Talks::getSlideNo() to always return an int

51ba665

Let PHPStan know that updating the row may throw an exception

c3d3f15

It was either PhpStorm complaining that the right part of `$slideNumber ?? ...` is useless, or PHPStan complaining that "Cannot access property $number on mixed." Or both.

Ensure the input value is a string

f30c4ef

Don't care if not because it's gonna be a string, trust me.

spaze self-assigned this Jun 27, 2023

spaze mentioned this pull request Jun 21, 2023

PHPStan Level 9 #147

Closed

spaze merged commit 46fe51e into main Jun 27, 2023

spaze deleted the spaze/phpstan-level-9-progress branch June 27, 2023 18:35

This was referenced Jul 1, 2023

ShouldNotHappenException No original request where 404 should be returned #158

Closed

PHPStan level 9 progress part 2 #156

Merged

spaze added a commit that referenced this pull request Jul 2, 2023

Sometimes the exception coming to error presenters is an Error, not j…

0899f05

…ust Exception Introduced somewhere in #155

spaze mentioned this pull request Jul 2, 2023

Sometimes the exception coming to error presenters is an Error, not just Exception #165

Merged

spaze added a commit that referenced this pull request Jul 2, 2023

Sometimes the exception coming to error presenters is an Error, not…

7f7790f

… just `Exception` (#165) Introduced somewhere in #155

spaze mentioned this pull request Jul 6, 2023

Certmonitor false positive errors for newly issued certs #167

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHPStan level 9 progress #155

PHPStan level 9 progress #155

spaze commented Jun 27, 2023

PHPStan level 9 progress #155

PHPStan level 9 progress #155

Conversation

spaze commented Jun 27, 2023