Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send UPC-keys-as-text with a method, not a template #189

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Send UPC-keys-as-text with a method, not a template #189

merged 3 commits into from
Jul 27, 2023

Commits on Jul 27, 2023

  1. Send UPC-keys-as-text with a method, not a template 

    This is because an extra template means it could be displayed even without the action/render method in the presenter. Well, not in this case, because the router wouldn't allow it, but in general. See the note below the diagram here https://doc.nette.org/en/application/presenters#toc-life-cycle-of-presenter

I could move the template to some other directory but I think just building the string is faster and simpler.

Ref efabrica-team/phpstan-latte#415
    @spaze
    spaze committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    89efe70 View commit details
    Browse the repository at this point in the history

  2. Partially revert #188 (this unignores the error message ignored there)

    @spaze
    spaze committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6800d9c View commit details
    Browse the repository at this point in the history

  3. God is a ~~DJ~~ tester

    @spaze
    spaze committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    3c2fbc8 View commit details
    Browse the repository at this point in the history