Write test for BlogPostPreview::sendPreview()
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate()` call It still works even if not passed, because it uses `getTemplate()` inside but let's be explicit.
To avoid all blog post preview errors. This test successfully detects all the issues reported in #169.
…e repository checkout There are some hardcoded paths in the config that are hard to change and are needed for rendering the blog post template: - SRI extension path to CSS, JS etc. - SVG icons paths These could be set/overwritten in the test with ```php $this->sriConfig->setLocalPrefix((object)['path' => __DIR__ . '/../../../public/www.michalspacek.cz']); PrivateProperty::setValue($this->svgIconNodeFactory, 'iconsDir', __DIR__ . '/../../../node_modules/humbleicons/icons'); ``` But then you get "Cannot modify readonly property Spaze\SvgIcons\Nodes\IconNodeFactory::$iconsDir" Creating a custom template where neither SRI nor SVG icons are needed would be possible but then things like "Component with name 'articleHeaderIcons' does not exist" from #169 would not be tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid all blog post preview errors. This test successfully detects all the issues reported in #169.