Support the new ARES (Administrativní registr ekonomických subjektů) version #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version The new version uses JSON instead of XML. The announcement: https://wwwinfo.mfcr.cz/ares/ares_info.html.cz https://web.archive.org/web/20230914225112/https%3A%2F%2Fwwwinfo.mfcr.cz%2Fares%2Fares_info.html.cz See https://ares.gov.cz/stranky/vyvojar-info & https://ares.gov.cz/swagger-ui/ for the docs. This is using the /ekonomicke-subjekty endpoint because it returns DIČ/tax id as well.
spaze
added a commit
that referenced
this pull request
Sep 25, 2023
They now probably add it themselves. Followup to #225
spaze
added a commit
that referenced
this pull request
Sep 25, 2023
They now probably add it themselves. Followup to #225
Merged
spaze
added a commit
that referenced
this pull request
Oct 16, 2023
I don't understand why but for this 'res' source, the country code is returned as "1", yes a string, instead of "cz", so let's deal with that. This wasn't happening when I've build the support in #225. It could be easily removed in the future, and there's a test for it (the one for the company with id 00256081), so if it is removed and it shouldn't be, I should know about it rather soon. Fix #242 The test querying the service is marked as "skipped" because it uses the Internet to actually query the live service and I don't want to query it when I'm running my tests in dev env for example. But I'd like to run the tests someday, so I've introduced a way to run all skipped tests, just define an environment variable `TEST_CASE_RUNNER_INCLUDE_SKIPPED=1` and run the test case again. Will also do it automatically with GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version uses JSON instead of XML.
The announcement & archived
See https://ares.gov.cz/stranky/vyvojar-info & https://ares.gov.cz/swagger-ui/ for the docs.
This is using the
/ekonomicke-subjektyendpoint because it returns DIČ/tax id as well.Follow-ups & bugs: