Add well-known URL for changing passwords in admin #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redirect is done in Nette so that I can redirect to presenter:action and not a URL. If the redirect would be done in server config, then it's one more place to change if the URL changes. Also not added as a one-way route to Nette because the redirection should be a temporary redirect while the one-way route redirect is a permanent one. See the spec here https://www.w3.org/TR/change-password-url/
spaze
added a commit
that referenced
this pull request
Mar 14, 2023
Well, I'm the only one using the login forms on this site but still wanted to try these. - Raise min length to 15 chars - Help password managers understand the form fields - Indicate which account is the password being changed for - Tell 1Password to generate a bit longer+stronger password by default TIL the `passwordrules` attribute thanks to this great @ScottHelme's blog post https://scotthelme.co.uk/boosting-account-security-pwned-passwords-and-zxcvbn/ Here are some helpful links: - [Design your website to work best with 1Password](https://developer.1password.com/docs/web/compatible-website-design/) - [Password Rules Validation Tool](https://developer.apple.com/password-rules/) by Apple, apparently supported in Safari [since 2018 (Safari 12)](https://webkit.org/blog/8327/safari-technology-preview-58-with-safari-12-features-is-now-available/) - whatwg/html#3518 _This is a companion to #89._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<admin>/.well-known/change-passwordwill now redirect to the page where you, or actually just I, can change my password. This is for a nicer integration with 1Password.The redirect is done in Nette so that I can redirect to
presenter:actionand not a URL. If the redirect would be done in server config, then it's one more place to change if the URL changes. Also not added as a one-way route to Nette because the redirection should be a temporary redirect while the one-way route redirect is a permanent one.See the spec here https://www.w3.org/TR/change-password-url/