Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
base: feedback
Are you sure you want to change the base?
Feedback #1
Changes from 66 commits
c684c27
2440aca
3a6e826
551bf1b
4a156c0
d64f79b
f77fa40
04961ce
1c09271
1c58d50
095a1f3
4ce4b0b
4e46238
81095ba
5779c31
18d2f20
bec9900
6f0866a
d70caab
fb4350f
eb6ba6e
1d6ea04
5314ceb
2006ec6
391e531
cf8e545
ac0da2c
54913ce
ab4e10d
c95cf57
926994c
860f2c4
18fcb15
9b79a9f
2da358f
29fd243
0bb9a28
97f5e9c
de7d352
a9cd189
40c6bf0
eb5bd20
840d256
67f1beb
209197e
b811a9d
36b408e
2dd00ac
439eff7
8504510
49235b4
85c0f1a
bcc69b3
dca9235
5decda6
9edffc9
8965444
8c7a31c
62a655e
4a973be
6f2f97d
06e414b
54d2d1e
8499471
733bdc0
893ff31
6ee14b3
42d906a
f85d29a
d613138
e4c8de2
b102436
9df571c
6f47c8e
6e769bf
cf5d1f3
6ba1546
dab9995
25a6fb2
4df2204
0ee304e
737623c
ad89890
10ad5bb
4a940a4
fc1ba27
05bc89f
fa8124e
d764fe0
b44b5d7
6d0f73b
1438bcd
cb8506b
f8c9dfd
50f9f7c
e270336
2d4ec8b
dcc1a30
d7668de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Из документации не очевидно, чем является saveToJson и как определяется то, под каким названием сохраняется файл. Если исходя из последнего параметра класса BSTree, то, вероятно, вы хотите разделить функциональность сохранения во внешние хранилища от конкретного способа представить дерево. Это обеспечит более слабую связанность компонентов.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Судя по документации предполагается, что пользователь моделей имеет полный доступ к таблицам.
Возможно стоит ограничить доступ к Entities базы данных через функции.
Например, производить создание row в таблице только по name и переданному дереву.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Что предоставляет
bst
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Все файлы с таким названием мусор из macos. Им не место в репозитории. Обновите .gitignore добавив
.DS_Store