Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROCm issue where target ID is set to gfxgfx*** #1290

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Fix ROCm issue where target ID is set to gfxgfx*** #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acc043d
fix ROCm issue where compute version is set to gfxgfxXXX
computablee Jun 30, 2023
13661c7
added my name as a contributor
computablee Jun 30, 2023
c80ee31
use startswith instead of 'in'
computablee Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@ Tiancheng Chen
Reid Wahl
Yihang Luo
Alexandru Calotoiu
Phillip Lane

and other contributors listed in https://github.com/spcl/dace/graphs/contributors
2 changes: 1 addition & 1 deletion dace/codegen/targets/cuda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ def cmake_options():
hip_arch = [ha for ha in hip_arch if ha is not None and len(ha) > 0]

flags = Config.get("compiler", "cuda", "hip_args")
flags += ' ' + ' '.join('--offload-arch=gfx{arch}'.format(arch=arch) for arch in hip_arch)
flags += ' ' + ' '.join('--offload-arch={arch}'.format(arch=arch if arch.startswith("gfx") else "gfx" + arch) for arch in hip_arch)
options.append("-DEXTRA_HIP_FLAGS=\"{}\"".format(flags))

if Config.get('compiler', 'cpu', 'executable'):
Expand Down