Refactor how icon TP states are created/removed: #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Smarter updates When tiling properties change, does not remove any states which will still exist in the new tiling layout (fixes #11); * Create states explicitly when icons are initially created instead of needing to check before every delivery; * Drop the `DynamicIcons.stateCreated` property and instead use a default empty `tile` to indicate state(s) need creation;
mpaperno
force-pushed
the
mp/11_tile_states
branch
from
41bf3a4 to
9e2cc45
Compare
spdermn02
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicIcons.stateCreatedproperty and instead use a default emptytileto indicate a new icon with no corresponding State yet.There's a bit more code involved of course to be "smart" about the tile states, but overall this motivated an optimization because it's not checking
createTpIconStateIfNeeded()/stateCreatedall the time anymore.