Add plugin setting to control default base image directory #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e image file paths. **NOTE**: This changes the default image base path from the plugin's installed directory to TP's config directory, two levels up. Relative paths in any existing actions will need to be updated.
spdermn02
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the plugin's install folder as the default base path was awkward and pretty useless. This changes the default image base path from the plugin's installed directory to TP's config directory, two levels up. Relative paths in any existing actions will need to be updated.
And the base path can now be set by the user with "Default Image Files Path" setting.
If there's a better cross-platform way to determine TP's config folder, I'm all for it.
https://github.com/spdermn02/TouchPortal-Dynamic-Icons/pull/8/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R31