Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug logging is too verbose #24

Closed
mpaperno opened this issue Sep 30, 2022 · 0 comments
Closed

Debug logging is too verbose #24

mpaperno opened this issue Sep 30, 2022 · 0 comments
Assignees
@spdermn02

Comments

@mpaperno
Copy link
Collaborator

As discussed, there is very little, if any, value added by the API logging each message from TP. It is, on the other hand, rather expensive. When firing actions/connectors rapidly, it can result in multiple log entries per millisecond. A serious slowdown in performance. I think plugin devs can just log whatever they need for debug anyway, and the default API logging really just gets in the way.
@spdermn02 spdermn02 self-assigned this Feb 14, 2023
spdermn02 added a commit that referenced this issue Feb 14, 2023
@spdermn02
perf(logging): ⚡ [NONE-1] Remove all DEBUG level logging from index
054e705 
No need to use DEBUG logging that is just more for edification during
initial development, the caller can handle any logging they want

Fixes: Debug logging is too verbose #24
@spdermn02 spdermn02 mentioned this issue Feb 14, 2023
Merged
spdermn02 added a commit that referenced this issue Feb 14, 2023
@spdermn02
perf(logging): ⚡ [NONE-1] Remove all DEBUG level logging from index (#29
90971f8 
)

No need to use DEBUG logging that is just more for edification during
initial development, the caller can handle any logging they want

Fixes: Debug logging is too verbose #24
@mpaperno mpaperno closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spdermn02 spdermn02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpaperno @spdermn02