Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License information in file should not be mandatory #130

Closed
armintaenzertng opened this issue Oct 11, 2022 · 1 comment · Fixed by #133
Closed

License information in file should not be mandatory #130

armintaenzertng opened this issue Oct 11, 2022 · 1 comment · Fixed by #133
Assignees
@goneall

Comments

@armintaenzertng
Copy link

According to spec, the field "License information in file" can be omitted.
This clashes with the SpdxFileBuilder where licenseInfosFromFile is required to be non-null.
@armintaenzertng armintaenzertng mentioned this issue Oct 11, 2022
Open
@goneall
Copy link
Member

goneall commented Oct 11, 2022

@armintaenzertng Good catch - I probably missed this update when updating for the SPDX 2.3 spec update.

@goneall goneall self-assigned this Oct 11, 2022
goneall added a commit that referenced this issue Oct 13, 2022
@goneall
Make licenseInfoInFile optional in SdpxFileBuilder
2a641d6 
Fixes #130

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall mentioned this issue Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goneall goneall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make licenseInfoInFile optional in SdpxFileBuilder spdx/Spdx-Java-Library
2 participants
@goneall @armintaenzertng