Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete relationships on RelatedElementCollection.remove #127

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Delete relationships on RelatedElementCollection.remove #127

merged 3 commits into from
Oct 6, 2022

Conversation

goneall
Copy link
Member

@goneall goneall commented Oct 5, 2022

Fixes #126

Signed-off-by: Gary O'Neall gary@sourceauditor.com

@goneall
Delete relationships on RelatedElementCollection.remove
f86cae4 
Fixes #126

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall mentioned this pull request Oct 5, 2022
Closed
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 5, 2022

⚠️ 28 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

nicoweidner
nicoweidner reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@nicoweidner nicoweidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue, thanks!
I noticed that the return value of RelatedElementCollection#remove changed in some cases - not sure if it matters (depends on its usage), but that probably deserves another look.

src/main/java/org/spdx/library/model/RelatedElementCollection.java Outdated Show resolved Hide resolved
src/test/java/org/spdx/library/model/SpdxDocumentTest.java Outdated Show resolved Hide resolved
@goneall
Fix return value and check for created
ea05b70 
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall
Remove extra comment
4ecd413 
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall merged commit 011e427 into master Oct 6, 2022
@goneall goneall deleted the issue126 branch October 6, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoweidner nicoweidner nicoweidner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference count is not decreased in certain situations
2 participants
@goneall @nicoweidner