Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec-parser errors #443

Closed
goneall opened this issue Jul 28, 2023 · 6 comments
Closed

Spec-parser errors #443

goneall opened this issue Jul 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@goneall
Copy link
Member

goneall commented Jul 28, 2023

Since merging in PR #441 we're getting the following error from the spec-parser:

Traceback (most recent call last):
  File "/home/runner/work/spdx-3-model/spdx-3-model/spec-parser/main.py", line 71, in <module>
    spec.gen_rdf()
  File "/home/runner/work/spdx-3-model/spdx-3-model/spec-parser/spec_parser/utils.py", line 188, in gen_rdf
    convert_spdx_owl_to_jsonld_context(jsonld_file_name, self.args["out_dir"])
  File "/home/runner/work/spdx-3-model/spdx-3-model/spec-parser/spec_parser/owl_to_context.py", line 50, in convert_spdx_owl_to_jsonld_context
    type_id = node["rdfs:range"]["@id"]
              ~~~~~~~~~~~~~~~~~~^^^^^^^
TypeError: string indices must be integers, not 'str'
Error: Process completed with exit code 1.
@goneall goneall added the bug Something isn't working label Jul 28, 2023
@goneall goneall added this to the 3.0-rc2 milestone Jul 28, 2023
@goneall
Copy link
Member Author

goneall commented Jul 28, 2023

@armintaenzertng - Can you take a look? I don't think it is related to the PR since the file changed shouldn't even be parsed.

@zvr
Copy link
Member

zvr commented Jul 28, 2023

I think it was because of the merge of spdx/spec-parser#58.

I might take a look tomorrow, as I'm working on the spec-parser anyway.

FYI, @armintaenzertng will be back after 15th.

@goneall goneall mentioned this issue Jul 28, 2023
@goneall
Copy link
Member Author

goneall commented Jul 28, 2023

I think it was because of the merge of spdx/spec-parser#58.

I might take a look tomorrow, as I'm working on the spec-parser anyway.

FYI, @armintaenzertng will be back after 15th.

Thanks @zvr

@zvr
Copy link
Member

zvr commented Jul 28, 2023

OK, little debugging before midnight:
it fails because the /Software/declaredLicense property has Range: /Licensing/AnyLicenseInfo and there is no more /Licensing namespace...

@goneall you probably know what to do.

I should point out that these will eventually be Relationships, so they might as well get deleted and two RelationshipTypes be added.

@goneall
Copy link
Member Author

goneall commented Jul 29, 2023

OK, little debugging before midnight

Thanks @zvr - I'll take care of it - I'll create the PR to fix the failures and RelationshipTypes.

@goneall goneall assigned goneall and unassigned zvr Jul 29, 2023
goneall added a commit that referenced this issue Jul 29, 2023
Implements decision made on whether licenses should be
a property or relationship on the 2023-05-02 tech call

Note that this introduces issues as documented in #254

This fixes the parsing errors #443

Also fixes #Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
goneall added a commit that referenced this issue Aug 1, 2023
Implements decision made on whether licenses should be
a property or relationship on the 2023-05-02 tech call

Note that this introduces issues as documented in #254

This fixes the parsing errors #443

Also fixes #Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall
Copy link
Member Author

goneall commented Aug 4, 2023

Resolved with PR #448

@goneall goneall closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants