Security: change Boolean to xsd:boolean and fix justification type #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
goneall
approved these changes
May 8, 2023
jeff-schutt
requested changes
May 8, 2023
There was a problem hiding this comment.
@tsteenbe: I also noticed that VexStatusType is unused; is this obsolete or was it forgotten to add to a class?
IIRC this is an obsolete leftover from an outdated model diagram b/c these definitions are now found at /model/Core/Vocabularies/RelationshipType.md. @puerco do you agree?
Great work @armintaenzertng!
model/Security/Classes/VexNotAffectedVulnAssessmentRelationship.md
Outdated
Show resolved
Hide resolved
…x typos Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
jeff-schutt
approved these changes
May 9, 2023
puerco
approved these changes
May 14, 2023
There was a problem hiding this comment.
Thanks @armintaenzertng decisionType and justificationType feel much more consistent with the overall model.
Yep, the status vocabulary is no longer used as now the status is a relationship, thanks for catching that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the Security profile, I noticed these small issues.
@tsteenbe: I also noticed that VexStatusType is unused; is this obsolete or was it forgotten to add to a class?