core: Replace Entity with Agent #340
Conversation
|
@sbarnum please review |
There was a problem hiding this comment.
Identity is also used in:
Core/Classes/Artifact.md
24: - type: Identity
27: - type: Identity
Core/Properties/originatedBy.md
17:- Range: Identity
Security/Classes/VulnAssessmentRelationship.md
31: - type: /Core/Identity
Entity is also used in:
Core/Classes/CreationInfo.md
31: - type: Entity
Core/Properties/createdBy.md
19:- Range: Entity
Core/Classes/Tool.md
16:- SubclassOf: Entity
These findings need to be migrated.
(Also: the spec-parser should probably fail and find these inconsistencies)
model/Core/Classes/Agent.md
Outdated
|
|
||
| ## Summary | ||
|
|
||
| Agent represents anything acting on a system. |
There was a problem hiding this comment.
Suggest changing to "An entity that has the potential to act."
This would align it with the the basic definitions of agent in the W3C PROVO ontology, FIBO ontology, FOAF ontology, and dbpedia ontology.
It also leaves it minimal and flexible for 3.0 as was agreed to.
model/Core/Classes/Agent.md
Outdated
|
|
||
| ## Description | ||
|
|
||
| The Agent class represents anything acting on a system. This could be a user account, or person. This is not to be confused with tools that perform tasks. |
There was a problem hiding this comment.
Suggest changing to "The Agent class represents anything that has the potential to act.. This could be a person, organization, software agent, etc. This is not to be confused with tools that are used to perform tasks."
Agent is not limited to acting on a system but rather acting in any way or context.
model/Core/Classes/SoftwareAgent.md
Outdated
|
|
||
| ## Description | ||
|
|
||
| A SoftwareAgent is a software representation of a user that could be assigned authorization to perform tasks on behalf of a person or organization. |
There was a problem hiding this comment.
Suggest changing to: "A SoftwareAgent is a software program with the potential to act on behalf of a user (person or organization) when it possesses appropriate authority."
The word representation has potential confusion of being interpreted as a facsimile. Really the software agent is acting "on behalf of" the user.
There was a problem hiding this comment.
From discussion in meeting:
A SoftwareAgent is a software program that is given the authority (similar to a user's authority) to perform an operation.
nishakm
force-pushed
the
94-update-agent
branch
4 times, most recently
from
06cbdbd
to
b87245b
Compare
- Replace concrete class Entity with concrete class Agent - Delete class Identity - Add new class SoftwareAgent - Make Person and Organization inherit from Agent - Make Tool inherit from Element Fixes: spdx#94 Signed-off-by: nisha <nisha@ctlfsh.tech>
Fixes: #94