Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SBOMType to SbomType #405

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Change SBOMType to SbomType #405

merged 2 commits into from
Jul 4, 2023

Conversation

davaya
Copy link
Contributor

@davaya davaya commented Jul 4, 2023

Use PascalCase for consistency with every other name in the model.

@armintaenzertng
Copy link
Contributor

I agree with the change, I stumbled upon this a few times.
However, this has to be changed in sbomType.md and Sbom.md, too.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this comment, can you also update sbomType.md and Sbom.md?

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davaya

@goneall goneall merged commit 37ca9f5 into spdx:main Jul 4, 2023
1 check passed
@davaya davaya deleted the fixcase branch July 5, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants