Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate the JSON-LD format #406

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Consolidate the JSON-LD format #406

merged 1 commit into from
Jul 5, 2023

Conversation

armintaenzertng
Copy link
Contributor

While there is still discussion surrounding the JSON serialization, this is an attempt to consolidate the JSON-LD format as a pure RDF format. This does not mean it can't be reused as a JSON serialization in the future, but please keep JSON discussions out of this PR for now.

This should bring us closer to a first functioning serialization that people can implement and try out.

goneall
goneall approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and agree we can include the RDF serialization JSON-LD as a starting example.

maxhbr
maxhbr approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that is a good next step

zvr
zvr requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't go through all of the examples, but I would like to see enumerated values being correct.

serialization/rdf.md Outdated Show resolved Hide resolved
serialization/json_ld/examples/spdx_document4.json Show resolved Hide resolved
@armintaenzertng
update JSON-LD examples and add documentation
39360b2 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
Copy link
Contributor Author

FYI: I deleted the alias element for @graph as it clashed with the already established key element. If someone has a better name for it, please come forth. :)
On the other hand, it might be consistent to have two top-level keys beginning with "@".

@zvr
Copy link
Member

zvr commented Jul 5, 2023

I think this is fine for merging, and we can iterate improving it afterwards.

@zvr zvr merged commit 5003212 into spdx:main Jul 5, 2023
@armintaenzertng armintaenzertng deleted the more_json-ld_examples branch July 5, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@maxhbr maxhbr maxhbr approved these changes

@zvr zvr zvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armintaenzertng @zvr @goneall @maxhbr