-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update security suppliedBy.md range to point to core suppliedby.md #488
Conversation
I don't think we can have a duplicate suppliedBy in a different namespace. I think the approach we should use is to just reference the core namespace where we referenced the supplied by property per my suggestion #436 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussed in the Defects meeting of Sept 6th, 2023 by @goneall @jeff-schutt @rnjudge @tsteenbe - MarkDown encoding for this pull request is now correct but spec parser needs to be updated by @goneall before this can be merged see spdx/spec-parser#68. |
Turns out I was wrong on the analysis of the CI failure - this is failing due to the Jinja changes - not due to handling /Core. I tested this change locally on my machine with an earlier version of the spec-parser and it works, so this is safe to merge. |
Just a note: this is a fix for the CI failure: spdx/spec-parser#69 |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed on call. Looks good.
To be merged once we merge the new parser - cc: @zvr |
The parser has been updated - merging... |
3rd change to resolve #436
Intent is to have the suppliedBy property in the security profile reuse the suppliedBy property defined in the Core profile to avoid duplication of definitions.