Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of empty copyrightText string #688

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

swinslow
Copy link
Member

@swinslow swinslow commented Apr 2, 2024

This PR just clarifies that an "empty" copyrightText string should be interpreted as equivalent to NOASSERTION.

Fixes #655

Signed-off-by: Steve Winslow steve@swinslow.net

Signed-off-by: Steve Winslow <steve@swinslow.net>
@swinslow swinslow added this to the 3.0 milestone Apr 2, 2024
@swinslow swinslow requested review from zvr and goneall April 2, 2024 16:33
@swinslow
Copy link
Member Author

swinslow commented Apr 2, 2024

@sschuberth @zvr @goneall I think this addresses the intended outcome of the consensus in #655, but feel free to revise or reject if I've gotten it wrong.

@@ -27,6 +27,11 @@ following applies:
* the SPDX data creator has intentionally provided no information (no
meaning should be implied by doing so).

If a copyrightText is present, but consists of solely an empty string or a
string with no substantive content (e.g., a string that contains only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO "no substantive content" is a bit too fluffy (as this commit intends to clarify things). For example, some people could interpret the literal copyright holder "E.G." as non-substantive as they might interpret it as "exempli gratia", i.e. a placeholder, whereas other might interpret it as initials of a name.

Thus, I propose to clearly say

If a copyrightText is present but empty or solely consists of whitespace, it should be interpreted as equivalent to a "NOASSERTION" value as described above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree that it should only cover empty or blank strings; "no substantive content" is correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no substantive content" is correct.

I'm sorry, but this is exactly the problem we have with SPDX when it comes to real-world implementations: Legal language being used as a basis for technical specification. I'd have no idea how a validation tool should check for "no substantive content" concretely.

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in tech call, and change generally looks good to participants.

@goneall goneall merged commit 93f0b5b into spdx:main Apr 2, 2024
1 check passed
@swinslow swinslow deleted the copyright-text-empty branch April 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should a blank / empty copyrightText be interpreted?
5 participants