Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExternalIdentifierType and HashAlgorithm: update entry names in diagrams #714

Closed
wants to merge 2 commits into from
Closed

ExternalIdentifierType and HashAlgorithm: update entry names in diagrams #714

wants to merge 2 commits into from

Conversation

bact
Copy link
Collaborator

@bact bact commented Apr 12, 2024

Update entry names in diagrams to reflect current names in spec

  • cpe_2.2 -> cpe22
  • cpe_2.3 -> cpe23
  • crystalKyber -> crystalsKyber (typo)

@bact
ExternalIdentifierType: update entry names in diagrams
3db73c8 
Update entry names in diagrams to reflect current names in spec

- `cpe_2.2` -> `cpe22`
- `cpe_2.3` -> `cpe23`
- `crystalKyber` -> `crystalsKyber` (typo)
@bact bact mentioned this pull request Apr 12, 2024
Merged
@bact bact changed the title ExternalIdentifierType: update entry names in diagrams ExternalIdentifierType and HashAlgorithm: update entry names in diagrams Apr 12, 2024
@kestewart
Copy link
Contributor

@sbarnum - can you take a reivew pass here.

@kestewart kestewart modified the milestones: 3.0-rc3, 3.0 Apr 12, 2024
@bact
Copy link
Collaborator Author

bact commented Apr 13, 2024 •
edited
Loading

I have checked with the latest diagram (12 Apr 2024) from PR #703.

  • All ExternalIdentifierType (cpe22 and cpe23) are good now.

  • HashAlgorithm (crystalsKyber):

    • Fixed already in model Core Enumerations.svg
    • Not yet in model Core+Software.svg
    • There's still one instance of "crystalKyber" (without 's' before 'K') in the latest model.drawio.

@sbarnum
Copy link
Collaborator

sbarnum commented Apr 14, 2024

Fixed in #717

@sbarnum sbarnum closed this Apr 14, 2024
@bact bact deleted the update-diagram-hashalgorithm branch April 15, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbarnum sbarnum Awaiting requested review from sbarnum

@rnjudge rnjudge Awaiting requested review from rnjudge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @kestewart @sbarnum